Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/self): add default tags for self service users #6810

Merged
merged 4 commits into from
May 26, 2023
Merged

feat(xo-web/self): add default tags for self service users #6810

merged 4 commits into from
May 26, 2023

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented May 3, 2023 •
edited
Loading

Description

Add default tags for self service users.
Backend PR 6812.
This feature comes from a discussion between Olivier and a customer at the CloudFest event.

Screenshots

Capture d’écran de 2023-05-03 15-39-01
Capture d’écran de 2023-05-03 15-39-25

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this May 3, 2023
@MathieuRA MathieuRA requested a review from Rajaa-BARHTAOUI May 3, 2023 13:47
@MathieuRA MathieuRA mentioned this pull request May 4, 2023
Merged
@MathieuRA MathieuRA requested review from pdonias and removed request for Rajaa-BARHTAOUI May 5, 2023 09:32
@MathieuRA MathieuRA marked this pull request as ready for review May 9, 2023 12:48
@MathieuRA MathieuRA force-pushed the ui/self-default-tags branch from 2c65bf5 to 2ca5433 Compare May 9, 2023 12:50
@MathieuRA MathieuRA requested review from ByScripts and removed request for pdonias May 9, 2023 13:30
@ByScripts ByScripts requested a review from Rajaa-BARHTAOUI May 22, 2023 08:37
Rajaa-BARHTAOUI
Rajaa-BARHTAOUI reviewed May 22, 2023
View reviewed changes
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/self/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/self/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/self/index.js Outdated Show resolved Hide resolved
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI requested a review from pdonias May 22, 2023 15:11
pdonias
pdonias requested changes May 23, 2023
View reviewed changes
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Reference the server side PR in the description
  • Don't capitalize the commit message
  • Where are those tags being used? Is there a description of the feature request/specification somewhere?

@MathieuRA MathieuRA force-pushed the ui/self-default-tags branch from b8fb3f5 to e801935 Compare May 24, 2023 07:55
@MathieuRA MathieuRA changed the title feat(xo-web/self): Add default tags for self service users feat(xo-web/self): add default tags for self service users May 24, 2023
@MathieuRA MathieuRA force-pushed the ui/self-default-tags branch from dfd1446 to 7ca5041 Compare May 24, 2023 08:37
@MathieuRA MathieuRA requested a review from Rajaa-BARHTAOUI May 24, 2023 08:38
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI requested a review from pdonias May 25, 2023 08:59
@pdonias
Copy link
Member

pdonias commented May 25, 2023

@MathieuRA Could you rebase please?

@pdonias
Copy link
Member

pdonias commented May 25, 2023

As discussed, this will (probably) require a change in a separate PR: show the default tags in the UI during the VM creation to let the user remove them.

@MathieuRA MathieuRA force-pushed the ui/self-default-tags branch from 7ca5041 to eb4ad40 Compare May 25, 2023 18:02
@MathieuRA
Copy link
Member Author

@pdonias Done.

@pdonias pdonias merged commit 98caa89 into master May 26, 2023
@pdonias pdonias deleted the ui/self-default-tags branch May 26, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByScripts ByScripts ByScripts approved these changes

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI Rajaa-BARHTAOUI approved these changes

@pdonias pdonias pdonias approved these changes

Assignees

@MathieuRA MathieuRA

Labels
Highlight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MathieuRA @pdonias @ByScripts @Rajaa-BARHTAOUI