Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/render-xo-item/PIF): add VLAN number #6714

Merged
merged 5 commits into from
Mar 15, 2023
Merged

Conversation

Rajaa-BARHTAOUI
Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI commented Mar 9, 2023

Fixes #4697

Gifs

Peek 2023-03-14 14-58

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

Copy link
Member

@MathieuRA MathieuRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a screenshot.

packages/xo-web/src/common/render-xo-item.js Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias March 9, 2023 14:29
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add.

@MathieuRA MathieuRA requested a review from pdonias March 10, 2023 08:47
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI requested review from pdonias and removed request for pdonias March 14, 2023 10:41
@pdonias pdonias changed the title feat(xo-web): Add VLAN number when displaying VLAN PIF feat(xo-web/render-xo-item/PIF): add VLAN number Mar 15, 2023
@pdonias pdonias merged commit 2823af9 into master Mar 15, 2023
@pdonias pdonias deleted the diff-vlan-pif branch March 15, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[xo-web/new/network] Differentiate VLAN PIF from PHYSICAL PIF
3 participants