Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/health): fix "an error has occurred" #6508

Merged
merged 6 commits into from
Nov 8, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Nov 2, 2022

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA self-assigned this Nov 2, 2022
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Co-authored-by: Pierre Donias <[email protected]>
@julien-f julien-f changed the title fix(health): fix an error as occured fix(xo-web/health): fix an error as occured Nov 3, 2022
@MathieuRA MathieuRA changed the title fix(xo-web/health): fix an error as occured fix(xo-web/health): fix an error as occurred Nov 3, 2022
@MathieuRA MathieuRA changed the title fix(xo-web/health): fix an error as occurred fix(xo-web/health): fix an error has occurred Nov 4, 2022
@pdonias pdonias changed the title fix(xo-web/health): fix an error has occurred fix(xo-web/health): fix "an error has occurred" Nov 8, 2022
@pdonias pdonias merged commit 12e98bf into master Nov 8, 2022
@pdonias pdonias deleted the mathieu/fixUserSrsUndefined branch November 8, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants