Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backups,xo-web): add cleanVm warnings to task #6225

Merged
merged 2 commits into from
May 30, 2022
Merged

Conversation

ByScripts
Copy link
Contributor

@ByScripts ByScripts commented May 9, 2022

Logging spec:

  • cases resulting from errors: warning
  • cases resulting from normal conditions: info
  • actions taken: info

Screenshot

Screen Shot 2022-05-12 at 10 05 40 AM

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@ByScripts ByScripts changed the title WiP: Send clean VM warnings to UI WiP: feat(backups) Display infos and warnings on UI May 11, 2022
@ByScripts ByScripts requested a review from fbeauchamp May 11, 2022 14:49
@xen-orchestra/backups/writers/_MixinBackupWriter.js Outdated Show resolved Hide resolved
@xen-orchestra/backups/writers/_MixinBackupWriter.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/index.js Outdated Show resolved Hide resolved
@ByScripts ByScripts changed the title WiP: feat(backups) Display infos and warnings on UI feat(backups) Display warnings on UI May 12, 2022
@ByScripts ByScripts marked this pull request as ready for review May 12, 2022 07:59
@ByScripts ByScripts requested a review from julien-f May 12, 2022 09:09
@ByScripts ByScripts force-pushed the feat_clean_vm_logs branch from 09b1073 to 9d36c28 Compare May 16, 2022 13:55
@julien-f julien-f requested review from julien-f and fbeauchamp and removed request for julien-f May 18, 2022 09:56
@fbeauchamp fbeauchamp requested a review from julien-f May 19, 2022 12:32
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@ByScripts ByScripts requested a review from julien-f May 24, 2022 06:43
@ByScripts ByScripts force-pushed the feat_clean_vm_logs branch from d576531 to efa80c3 Compare May 24, 2022 07:08
@ByScripts ByScripts force-pushed the feat_clean_vm_logs branch from efa80c3 to 3e10433 Compare May 30, 2022 06:31
@ByScripts ByScripts requested a review from julien-f May 30, 2022 06:33
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@ByScripts ByScripts force-pushed the feat_clean_vm_logs branch from 8421c59 to a8cc871 Compare May 30, 2022 13:01
@julien-f julien-f changed the title feat(backups) Display warnings on UI feat(backups,xo-web): add cleanVm warnings to task May 30, 2022
@julien-f julien-f merged commit c0b0ba4 into master May 30, 2022
@julien-f julien-f deleted the feat_clean_vm_logs branch May 30, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants