Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xapi/VM_{checkpoint,snapshot}): complete NOBAK support #6208

Merged
merged 2 commits into from
May 3, 2022

Conversation

julien-f
Copy link
Member

Fixes #2560

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@julien-f julien-f requested a review from fbeauchamp April 28, 2022 13:13
@olivierlambert
Copy link
Member

Is it tested functionally?

@julien-f
Copy link
Member Author

I've tested it in CLI, not in a complete backup yet.

@xen-orchestra/xapi/cli.js Show resolved Hide resolved
@xen-orchestra/xapi/vm.js Outdated Show resolved Hide resolved
@xen-orchestra/xapi/vm.js Show resolved Hide resolved
@xen-orchestra/xapi/vm.js Outdated Show resolved Hide resolved
@xen-orchestra/backups/_deltaVm.js Show resolved Hide resolved
@xen-orchestra/xapi/vm.js Outdated Show resolved Hide resolved
@julien-f julien-f requested review from fbeauchamp and removed request for fbeauchamp May 2, 2022 10:00
@julien-f julien-f force-pushed the xapi-better-nobak branch from f186bba to ea771d4 Compare May 2, 2022 16:14
@julien-f julien-f requested a review from fbeauchamp May 2, 2022 16:14
@julien-f julien-f merged commit 7005c1f into master May 3, 2022
@julien-f julien-f deleted the xapi-better-nobak branch May 3, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Full backups] Supports [NOBAK]
3 participants