Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): support consoles behind HTTP proxy #6133

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Mar 5, 2022

This is a major change in the way xo-server connect to a console, from connecting directly as a TCP socket to using a WebSocket in binary mode.

This was already the case prior c17620e but was changed due to XenServer issues with their WebSocket console implementation, it appears to be working fine now.

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp force-pushed the feat_proxy_console branch 2 times, most recently from 7a9b641 to ed24ecd Compare March 7, 2022 14:38
@fbeauchamp fbeauchamp changed the title wip: feat(console): support HTTP proxy feat(console): support consoles behind HTTP proxy Mar 7, 2022
@fbeauchamp fbeauchamp requested a review from julien-f March 7, 2022 14:41
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp force-pushed the feat_proxy_console branch from ed24ecd to 54f81e3 Compare March 8, 2022 08:17
@fbeauchamp fbeauchamp force-pushed the feat_proxy_console branch from 54f81e3 to 5e6e4c9 Compare March 8, 2022 08:30
@fbeauchamp fbeauchamp requested a review from julien-f March 10, 2022 10:43
@julien-f julien-f merged commit c99120b into master Mar 10, 2022
@julien-f julien-f deleted the feat_proxy_console branch March 10, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants