fix(xo-server-audit): handle the case when db is empty on generateFingerprint #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuRA
changed the title
fbeauchamp
approved these changes
Jan 5, 2022
CHANGELOG.unreleased.md
Outdated
| @@ -12,6 +12,7 @@ | |||
| > Users must be able to say: “I had this issue, happy to know it's fixed” | |||
|
|
|||
| - [Dashboard/Health] Fix `error has occured` when a pool has no default SR | |||
| - [Plugin/Audit] Fix `key cannot be 'null' or 'undefined'` when no audit log in the database. [#6040](https://github.com/vatesfr/xen-orchestra/issues/6040) (PR [#6071](https://github.com/vatesfr/xen-orchestra/pull/6071)) | |||
There was a problem hiding this comment.
Suggested change
| - [Plugin/Audit] Fix `key cannot be 'null' or 'undefined'` when no audit log in the database. [#6040](https://github.com/vatesfr/xen-orchestra/issues/6040) (PR [#6071](https://github.com/vatesfr/xen-orchestra/pull/6071)) | |
| - [Plugin/Audit] Fix `key cannot be 'null' or 'undefined'` error when no audit log in the database. [#6040](https://github.com/vatesfr/xen-orchestra/issues/6040) (PR [#6071](https://github.com/vatesfr/xen-orchestra/pull/6071)) |
There was a problem hiding this comment.
Suggested change
| - [Plugin/Audit] Fix `key cannot be 'null' or 'undefined'` when no audit log in the database. [#6040](https://github.com/vatesfr/xen-orchestra/issues/6040) (PR [#6071](https://github.com/vatesfr/xen-orchestra/pull/6071)) | |
| - [Plugin/Audit] Fix `key cannot be 'null' or 'undefined'` error when no audit log in the database [#6040](https://github.com/vatesfr/xen-orchestra/issues/6040) (PR [#6071](https://github.com/vatesfr/xen-orchestra/pull/6071)) |
| return { | ||
| fingerprint: `${oldest}|${newest}`, | ||
| newest, | ||
| nValid: await this._checkIntegrity({ oldest, newest }), | ||
| nValid, |
There was a problem hiding this comment.
Suggested change
| nValid, | |
| nValid: newest !== NULL_ID ? await this._checkIntegrity({ oldest, newest }) : 0 |
pdonias
requested changes
Jan 14, 2022
CHANGELOG.unreleased.md
Outdated
| @@ -12,6 +12,7 @@ | |||
| > Users must be able to say: “I had this issue, happy to know it's fixed” | |||
|
|
|||
| - [Dashboard/Health] Fix `error has occured` when a pool has no default SR | |||
| - [Plugin/Audit] Fix `key cannot be 'null' or 'undefined'` when no audit log in the database. [#6040](https://github.com/vatesfr/xen-orchestra/issues/6040) (PR [#6071](https://github.com/vatesfr/xen-orchestra/pull/6071)) | |||
There was a problem hiding this comment.
Suggested change
| - [Plugin/Audit] Fix `key cannot be 'null' or 'undefined'` when no audit log in the database. [#6040](https://github.com/vatesfr/xen-orchestra/issues/6040) (PR [#6071](https://github.com/vatesfr/xen-orchestra/pull/6071)) | |
| - [Plugin/Audit] Fix `key cannot be 'null' or 'undefined'` error when no audit log in the database [#6040](https://github.com/vatesfr/xen-orchestra/issues/6040) (PR [#6071](https://github.com/vatesfr/xen-orchestra/pull/6071)) |
Rajaa-BARHTAOUI
approved these changes
Jan 19, 2022
pdonias
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6040
Description
In the case we where calling
audit.generateFingerprintwhen no audit log in database, an error was thrownCheck list
Fixes #007orSee xoa-support#42)CHANGELOG.unreleased.md:${name} v${new version})cron/parse.spec.js)xo-serverAPI changes, the corresponding test has been added to/updated onxo-server-testProcess
WiP:(Work in Progress) if not ready to be mergedFrom the Four Agreements: