SMB VDI share mount error - extra backslash on creation

[TristisOris]

Are you using XOA or XO from the sources?

XO from the sources

Which release channel?

None

Provide your commit number

838f9

Describe the bug

Can't connect to smb folder, probably due of extra backslashes at path.
Any slash at path\login transform into 2.

Error message

server: \\1.2.3.4\rp\distrib\xen-test
login: ad_domain\ad_login

sr.createSmb
{
  "host": "a3c0326a-325a-4cba-828e-c7035ec7fcb1",
  "nameLabel": "VM smb",
  "nameDescription": "smb share vc",
  "server": "\\\\1.2.3.4\\rp\\distrib\\xen-test",
  "user": "ad_domain\\ad_login",
  "password": "* obfuscated *"
}
{
  "code": "SR_BACKEND_FAILURE_111",
  "params": [
    "",
    "SMB mount error [opterr=mount failed with return code 32]",
    ""
  ],
  "call": {
    "method": "SR.create",
    "params": [
      "OpaqueRef:ec71c346-c5fa-4c2d-ad84-d31f053a2a42",
      {
        "server": "\\\\1.2.3.4\\rp\\distrib\\xen-test",
        "user": "ad_domain\\ad_login",
        "password": "* obfuscated *"
      },
      0,
      "VM smb",
      "smb share vc",
      "smb",
      "user",
      true,
      {}
    ]
  },
  "message": "SR_BACKEND_FAILURE_111(, SMB mount error [opterr=mount failed with return code 32], )",
  "name": "XapiError",
  "stack": "XapiError: SR_BACKEND_FAILURE_111(, SMB mount error [opterr=mount failed with return code 32], )
    at Function.wrap (file:///opt/xo/xo-builds/xen-orchestra-202402011054/packages/xen-api/_XapiError.mjs:16:12)
    at file:///opt/xo/xo-builds/xen-orchestra-202402011054/packages/xen-api/transports/json-rpc.mjs:35:21
    at runNextTicks (node:internal/process/task_queues:60:5)
    at processImmediate (node:internal/timers:447:9)
    at process.callbackTrampoline (node:internal/async_hooks:128:17)"
}

server: 1.2.3.4\rp\distrib\xen-test
login: ad_domain\ad_login

sr.createSmb
{
  "host": "a3c0326a-325a-4cba-828e-c7035ec7fcb1",
  "nameLabel": "VM smb",
  "nameDescription": "smb share vc",
  "server": "1.2.3.4\\rp\\distrib\\xen-test",
  "user": "ad_domain\\ad_login",
  "password": "* obfuscated *"
}
{
  "code": "SR_BACKEND_FAILURE_111",
  "params": [
    "",
    "SMB mount error [opterr=mount failed with return code 1]",
    ""
  ],
  "call": {
    "method": "SR.create",
    "params": [
      "OpaqueRef:ec71c346-c5fa-4c2d-ad84-d31f053a2a42",
      {
        "server": "1.2.3.4\\rp\\distrib\\xen-test",
        "user": "ad_domain\\ad_login",
        "password": "* obfuscated *"
      },
      0,
      "VM smb",
      "smb share vc",
      "smb",
      "user",
      true,
      {}
    ]
  },
  "message": "SR_BACKEND_FAILURE_111(, SMB mount error [opterr=mount failed with return code 1], )",
  "name": "XapiError",
  "stack": "XapiError: SR_BACKEND_FAILURE_111(, SMB mount error [opterr=mount failed with return code 1], )
    at Function.wrap (file:///opt/xo/xo-builds/xen-orchestra-202402011054/packages/xen-api/_XapiError.mjs:16:12)
    at file:///opt/xo/xo-builds/xen-orchestra-202402011054/packages/xen-api/transports/json-rpc.mjs:35:21
    at runNextTicks (node:internal/process/task_queues:60:5)
    at processImmediate (node:internal/timers:447:9)
    at process.callbackTrampoline (node:internal/async_hooks:128:17)"
}

server: \1.2.3.4\rp\distrib\xen-test
login: ad_domain\ad_login

sr.createSmb
{
  "host": "a3c0326a-325a-4cba-828e-c7035ec7fcb1",
  "nameLabel": "VM smb",
  "nameDescription": "smb share vc",
  "server": "\\1.2.3.4\\rp\\distrib\\xen-test",
  "user": "ad_domain\\ad_login",
  "password": "* obfuscated *"
}
{
  "code": "SR_BACKEND_FAILURE_111",
  "params": [
    "",
    "SMB mount error [opterr=mount failed with return code 1]",
    ""
  ],
  "call": {
    "method": "SR.create",
    "params": [
      "OpaqueRef:ec71c346-c5fa-4c2d-ad84-d31f053a2a42",
      {
        "server": "\\1.2.3.4\\rp\\distrib\\xen-test",
        "user": "ad_domain\\ad_login",
        "password": "* obfuscated *"
      },
      0,
      "VM smb",
      "smb share vc",
      "smb",
      "user",
      true,
      {}
    ]
  },
  "message": "SR_BACKEND_FAILURE_111(, SMB mount error [opterr=mount failed with return code 1], )",
  "name": "XapiError",
  "stack": "XapiError: SR_BACKEND_FAILURE_111(, SMB mount error [opterr=mount failed with return code 1], )
    at Function.wrap (file:///opt/xo/xo-builds/xen-orchestra-202402011054/packages/xen-api/_XapiError.mjs:16:12)
    at file:///opt/xo/xo-builds/xen-orchestra-202402011054/packages/xen-api/transports/json-rpc.mjs:35:21
    at runNextTicks (node:internal/process/task_queues:60:5)
    at processImmediate (node:internal/timers:447:9)
    at process.callbackTrampoline (node:internal/async_hooks:128:17)"
}

### To reproduce

1. Go to host, storage
2. Click on add storage
3. try to add smb vdi share



### Expected behavior

_No response_

### Screenshots

_No response_

### Node

18

### Hypervisor

8.2.1

### Additional context

_No response_

[MathieuRA]

Hi, thank you for your report.

The issue should be resolved on the branch fix-smb-storage

[TristisOris]

updated from branch, mount test smb folder. No errors.