Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect VDI depth and total VDI to coalesce count in SR advanced view #7016

Closed
olivierlambert opened this issue Sep 4, 2023 · 0 comments · Fixed by #7098
Closed

Incorrect VDI depth and total VDI to coalesce count in SR advanced view #7016

olivierlambert opened this issue Sep 4, 2023 · 0 comments · Fixed by #7098

Comments

@olivierlambert
Copy link
Member

On XOA latest, when creating 20 VMs from the same template, each new VM disk will have the VM disk template as parent (normal).

When you snapshot those VMs and then removing those VMs, we have an incorrect count on the depth and therefore VDI to coalesce.

Here is an example, before removing the snaps: https://paste.vates.tech/?945a3d4691ddf4f8#6GNREJhFBBbqEqXd995GTy2DicJspyngES7gSHLZV2YE

When removing the snapshots: https://paste.vates.tech/?a91210f37ddd5b89#BrVuqJLRF7BqPGKhzabf3AJUY2M9vjp533b2VhG2Bx1b

At this point, XO is reporting 201 VDIs to coalesce:

vdicount

Which is wrong. Also, we can see that some VDIs are counted with a depth of 18, which is not true either. I think the total count is doing a sum of the depth of each VDI, giving this wrong total number of VDI to coalesce.

@olivierlambert olivierlambert added this to the Q4 2023 milestone Sep 15, 2023
julien-f added a commit that referenced this issue Oct 17, 2023
Fixes #7016

Summing all chains does not common chains into account, the total must be computed on the server side.
pdonias pushed a commit that referenced this issue Oct 18, 2023
Fixes #7016

Summing all chains does take not common chains into account, the total must be computed on the server side.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment