WIP: Ensure that updates to the xenorchestra_vm resource properly han…

…dle XO api nullable fields
vatesfr · Apr 12, 2023 · 4cba195 · 4cba195
1 parent 60507a7
commit 4cba195
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 8 deletions.
diff --git a/client/vm.go b/client/vm.go
@@ -95,7 +95,7 @@ type Vm struct {
 	Boot               Boot              `json:"boot,omitempty"`
 	Type               string            `json:"type,omitempty"`
 	Id                 string            `json:"id,omitempty"`
-	AffinityHost       string            `json:"affinityHost,omitempty"`
+	AffinityHost       *string           `json:"affinityHost,omitempty"`
 	NameDescription    string            `json:"name_description"`
 	NameLabel          string            `json:"name_label"`
 	CPUs               CPUs              `json:"CPUs"`
@@ -212,7 +212,6 @@ func (c *Client) CreateVm(vmReq Vm, createTime time.Duration) (*Vm, error) {
 	}
 
 	params := map[string]interface{}{
-		"affinityHost":     vmReq.AffinityHost,
 		"bootAfterCreate":  true,
 		"name_label":       vmReq.NameLabel,
 		"name_description": vmReq.NameDescription,
@@ -241,6 +240,11 @@ func (c *Client) CreateVm(vmReq Vm, createTime time.Duration) (*Vm, error) {
 		params["hvmBootFirmware"] = firmware
 	}
 
+	affinityHost := vmReq.AffinityHost
+	if affinityHost != nil {
+		params["affinityHost"] = affinityHost
+	}
+
 	vga := vmReq.Vga
 	if vga != "" {
 		params["vga"] = vga

diff --git a/xoa/resource_xenorchestra_vm.go b/xoa/resource_xenorchestra_vm.go
@@ -407,8 +407,7 @@ func resourceVmCreate(d *schema.ResourceData, m interface{}) error {
 			Id: rsId.(string),
 		}
 	}
-	vm, err := c.CreateVm(client.Vm{
-		AffinityHost:      d.Get("affinity_host").(string),
+	createVmParams := client.Vm{
 		BlockedOperations: blockedOperations,
 		Boot: client.Boot{
 			Firmware: d.Get("hvm_boot_firmware").(string),
@@ -440,9 +439,13 @@ func resourceVmCreate(d *schema.ResourceData, m interface{}) error {
 			Value: d.Get("videoram").(int),
 		},
 		Vga: d.Get("vga").(string),
-	},
-		d.Timeout(schema.TimeoutCreate),
-	)
+	}
+
+	affinityHost := d.Get("affinity_host").(string)
+	if affinityHost != "" {
+		createVmParams.AffinityHost = &affinityHost
+	}
+	vm, err := c.CreateVm(createVmParams, d.Timeout(schema.TimeoutCreate))
 
 	if err != nil {
 		return err
@@ -778,7 +781,6 @@ func resourceVmUpdate(d *schema.ResourceData, m interface{}) error {
 		HA:                ha,
 		ResourceSet:       rs,
 		AutoPoweron:       autoPowerOn,
-		AffinityHost:      affinityHost,
 		BlockedOperations: blockOperations,
 		ExpNestedHvm:      d.Get("exp_nested_hvm").(bool),
 		StartDelay:        d.Get("start_delay").(int),
@@ -792,6 +794,11 @@ func resourceVmUpdate(d *schema.ResourceData, m interface{}) error {
 			Value: d.Get("videoram").(int),
 		},
 	}
+
+	if d.HasChange("affinity_host") && affinityHost != "" {
+		vmReq.AffinityHost = &affinityHost
+	}
+
 	if haltForUpdates {
 		err := c.HaltVm(id)