Improve quoting options #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves adds improved quoting options for CSVs:
-qor--quote_characterfor the APIQuoteCharacterfield-Qor--quote_escape_characterfor the APIQuoteEscapeCharacterfield-Aor--allow_quoted_record_delimiterfor the APIAllowQuotedRecordDelimiterfield (boolean)Note there is a minor change in behavior between this PR and commit 728788a, which itself introduces a change to quoting defaults by setting
QuoteCharacterto the empty string (with no option for configuration).I'd expect when no options are given behavior should be consistent with the defaults of
boto3and the underlying S3 Select API. This PR accomplishes that, while allowing other options to be used with-q/-Q/-A.