Fix expired authenticated public link error code (cs3org#3528)

vascoguita · Dec 8, 2022 · dd3333f · dd3333f
1 parent 8078ac6
commit dd3333f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/changelog/unreleased/fix-authenticated-expired-publiclinks.md b/changelog/unreleased/fix-authenticated-expired-publiclinks.md
@@ -0,0 +1,8 @@
+Bugfix: Fix expired authenticated public link error code
+
+On an expired authenticated public link, the error returned
+was 401 unauthorized, behaving differently from
+a not-authenticated one, that returns 404 not found.
+This has been fixed, returning 404 not found.
+
+https://github.com/cs3org/reva/pull/3528
diff --git a/pkg/cbox/publicshare/sql/sql.go b/pkg/cbox/publicshare/sql/sql.go
@@ -449,6 +449,12 @@ func (m *manager) GetPublicShareByToken(ctx context.Context, token string, auth
 		return nil, err
 	}
 	cs3Share := conversions.ConvertToCS3PublicShare(s)
+	if expired(cs3Share) {
+		if err := m.cleanupExpiredShares(); err != nil {
+			return nil, err
+		}
+		return nil, errtypes.NotFound(token)
+	}
 	if s.ShareWith != "" {
 		if !authenticate(cs3Share, s.ShareWith, auth) {
 			// if check := checkPasswordHash(auth.Password, s.ShareWith); !check {
@@ -462,13 +468,6 @@ func (m *manager) GetPublicShareByToken(ctx context.Context, token string, auth
 		}
 	}
 
-	if expired(cs3Share) {
-		if err := m.cleanupExpiredShares(); err != nil {
-			return nil, err
-		}
-		return nil, errtypes.NotFound(token)
-	}
-
 	return cs3Share, nil
 }