Skip computing groups when fetching all groups from grappa (cs3org#3719)

* skip computing groups * add changelog * fix * use 804d1777051c3583dfeebae467466f1316fa3583 commit
vascoguita · Mar 10, 2023 · af4c4c8 · af4c4c8
1 parent 8f0d1d7
commit af4c4c8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/changelog/unreleased/filter-computing-groups-grappa.md b/changelog/unreleased/filter-computing-groups-grappa.md
@@ -0,0 +1,3 @@
+Enhancement: Skip computing groups when fetching all groups from grappa
+
+https://github.com/cs3org/reva/pull/3719
diff --git a/pkg/cbox/group/rest/rest.go b/pkg/cbox/group/rest/rest.go
@@ -148,7 +148,7 @@ func (m *manager) fetchAllGroups() {
 
 func (m *manager) fetchAllGroupAccounts() error {
 	ctx := context.Background()
-	url := fmt.Sprintf("%s/api/v1.0/Group?field=groupIdentifier&field=displayName&field=gid", m.conf.APIBaseURL)
+	url := fmt.Sprintf("%s/api/v1.0/Group?field=groupIdentifier&field=displayName&field=gid&field=isComputingGroup", m.conf.APIBaseURL)
 
 	for url != "" {
 		result, err := m.apiTokenManager.SendAPIGetRequest(ctx, url, false)
@@ -166,6 +166,11 @@ func (m *manager) fetchAllGroupAccounts() error {
 				continue
 			}
 
+			// filter computing groups
+			if is, ok := groupData["isComputingGroup"].(bool); ok && is {
+				continue
+			}
+
 			_, err = m.parseAndCacheGroup(ctx, groupData)
 			if err != nil {
 				continue
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		Enhancement: Skip computing groups when fetching all groups from grappa

		https://github.com/cs3org/reva/pull/3719