Show color in ColorInputComponent, just like in ColorFieldComponent #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any news on if this can be merged? it would be a great feature |
|
I have published a fork of this package, called @palustris/react-admin-color-input. My package contains this change, but also a few others, ie. easier navigation using the keyboard. |
|
Thanks @gartner |
|
@gartner Thank you very much for your updated version. Maybe you can add support for empty values in ColorField. Currently it crashes because of ColorDot "TypeError: Cannot read property '0' of undefined" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a square, showing the current color of the ColorInputComponent, just like it is shown in ColorFieldComponent.