Modified gem dependency to include AR 4.x #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current gem dependency does allow for Rails 4, no? |
|
Ok my bad, I got a bundler error using the current gems at rubygems.org so I assumed it was an issue with the dependencies and I just fixed it a local clone. I then decided I may as well generate the pull request and here we are. I can confirm that specifying your github master explicitly in the Gemfile does work but gems at rubygems.org don't. Well its up to you, but it is probably much safer to be pessimistic with version deps, because AR 4.x -> AR 5.0 is likely to break things just as AR 3.x to AR 4.0 did. This seems to be a common defensive strategy used by many gems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix gem dependency to allow gem to be used with Rails 4.x