Update for current varnish-cache and polish #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
address recommendations from vmodtool
as of Varnish Cache 6.6.0
getting closer to vcdk this also fixes an error with parallel make.
The previous timestamp was before the timeout, so the delta should also be longer than one second.
nigoroll
added a commit
to nigoroll/varnish-cache
that referenced
this pull request
Jun 23, 2023
gquintard
reviewed
Jun 25, 2023
| @@ -15,8 +15,8 @@ varnish v1 -vcl+backend { | |||
| curl.set_timeout(200); | |||
| curl.set_connect_timeout(200); | |||
| } else { | |||
| curl.set_timeout(1300); | |||
| curl.set_connect_timeout(1300); | |||
| curl.set_timeout(1310); | |||
There was a problem hiding this comment.
I have a hard time believing that 10ms make a clean difference in general. Is there a known reason for that?
There was a problem hiding this comment.
The reason why I changed the timeout was that the test case reported a run time of 1.299something seconds. This seems a bit odd, but I did not consider it too relevant, have not looked at what libcurl does and just applied this change to make the test case pass.
|
looks good to me, but I don't have commit access anymore :-) |
|
I object to @gquintard's definition of a week. |
|
merged, thanks @nigoroll ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the vmod work and pass the test-suite with varnish-cache as of baf60b4d2ef5f418e6ac470f3562e43c37e2ad44
Please see individual commit messages.