Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More and more used filedescriptor after every reload #193

Closed
Csurgi opened this issue Jul 31, 2017 · 1 comment
Closed

More and more used filedescriptor after every reload #193

Csurgi opened this issue Jul 31, 2017 · 1 comment

Comments

@Csurgi
Copy link

Csurgi commented Jul 31, 2017

More and more filedescriptor used after configuration reload.

I have a hitch with 8 worker, and after I reload the config it's using 8 more fd after every reload.
Using:
hitch 1.4.6 from source with ./configure --prefix=/usr --sysconfdir=/etc
Under:
Ubuntu 15.10 Wily (because of openssl 1.0.2)

I'm using about 26k certificate, and reloading config after some minutes if any of them has been changed.
After starting hitch it's using 6 filedescriptors, after reloads it's using 14, 22, 30 .. 8006, etc.
There is no traffic, it's a test system now.

Configuration without certificates:
`

workers = 8
quiet = on
user = "hitch"
group = "hitch"
ocsp-dir = ""
ocsp-verify-staple = on
syslog = off
syslog-facility = "daemon"
write-proxy-v2 = on
alpn-protos = "http/2,http/1.1"
frontend = "[*]:443"
backend = "[127.0.0.1]:6086"
tls-protos = TLSv1.1 TLSv1.2
sni-nomatch-abort = off
prefer-server-ciphers = on
ciphers = "ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES128-SHA256:ECDHE-ECDSA-AES128-SHA:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA:ECDHE-ECDSA-AES256-SHA384:ECDHE-ECDSA-AES256-SHA:ECDHE-RSA-AES256-SHA:DHE-RSA-AES128-SHA256:DHE-RSA-AES128-SHA:DHE-RSA-AES256-SHA256:DHE-RSA-AES256-SHA:ECDHE-ECDSA-DES-CBC3-SHA:ECDHE-RSA-DES-CBC3-SHA:EDH-RSA-DES-CBC3-SHA:AES128-GCM-SHA256:AES256-GCM-SHA384:AES128-SHA256:AES256-SHA256:AES128-SHA:AES256-SHA:DES-CBC3-SHA:!DSS

"
`

@ghost ghost mentioned this issue Sep 14, 2017
daghf pushed a commit that referenced this issue Sep 21, 2017
Killing worker processes would leave the pipe's write end open,
leaking one file descriptor per worker upon reload.

Fixes issue #193.
@gquintard
Copy link
Contributor

@Csurgi would you mind trying master and see if you can reproduce? I believe this has been fixed in 0cef088.

If not, please re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants