Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new key addition API #166

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Add new key addition API #166

merged 2 commits into from
Jun 4, 2024

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented May 30, 2024

#165 noted that the key addition API isn't conform to the Swift style guidelines, this fixes that

@ptoffy ptoffy requested review from gwynne, 0xTim and MahdiBM May 30, 2024 14:01
@0xTim 0xTim linked an issue Jun 3, 2024 that may be closed by this pull request
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can roll out a new beta when merged

@gwynne
Copy link
Member

gwynne commented Jun 3, 2024

@ptoffy Please fix the CI 🤨

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 77.65%. Comparing base (c4828b0) to head (5cb99a8).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   73.56%   77.65%   +4.09%     
==========================================
  Files          59       60       +1     
  Lines        1615     1392     -223     
==========================================
- Hits         1188     1081     -107     
+ Misses        427      311     -116     
Files Coverage Δ
Sources/JWTKit/ECDSA/JWTKeyCollection+ECDSA.swift 100.00% <ø> (ø)
Sources/JWTKit/EdDSA/JWTKeyCollection+EdDSA.swift 100.00% <ø> (ø)
Sources/JWTKit/RSA/JWTKeyCollection+RSA.swift 85.71% <ø> (+52.38%) ⬆️
Sources/JWTKit/HMAC/HMAC.swift 75.00% <75.00%> (ø)
Sources/JWTKit/HMAC/JWTKeyCollection+HMAC.swift 75.00% <33.33%> (+41.66%) ⬆️

... and 26 files with indirect coverage changes

@0xTim 0xTim merged commit 1737318 into main Jun 4, 2024
7 of 9 checks passed
@0xTim 0xTim deleted the add-api branch June 4, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use syntax JWT application configuration
4 participants