Add unit tests for command output #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfallmk
approved these changes
Mar 15, 2018
| @@ -31,7 +31,7 @@ jobs: | |||
| name: "Installing Vendored Dependencies" | |||
| command: | | |||
| go get -v github.com/golang/dep/cmd/dep | |||
| go install github.com/golang/dep/cmd/dep | |||
| CGO_ENABLED=0 go install github.com/golang/dep/cmd/dep | |||
There was a problem hiding this comment.
Was this a specific flag you needed for building dep?!
There was a problem hiding this comment.
../../../../../usr/local/go/src/net/lookup_unix.go:107:23:warning: undeclared name: cgoLookupPort (interfacer)
../../../../../usr/local/go/src/net/lookup_unix.go:95:24:warning: undeclared name: cgoLookupIP (interfacer)
../../../../../usr/local/go/src/net/lookup_unix.go:80:24:warning: undeclared name: cgoLookupHost (interfacer)
../../../../../usr/local/go/src/net/lookup_unix.go:190:23:warning: undeclared name: cgoLookupPTR (interfacer)
../../../../../usr/local/go/src/net/lookup_unix.go:123:24:warning: undeclared name: cgoLookupCNAME (interfacer)
after doing some searching, that brought me to: alecthomas/gometalinter#149 (comment)
but I looked at the golang:latest which is being used in CI - it should have gcc installed, so I tried adding this flag and voilà, it worked!
| for d in $(go list ./... | grep -v vendor); do | ||
| go test -race -coverprofile=profile.out -covermode=atomic ${d} | ||
| if [ -f profile.out ]; then | ||
| cat profile.out | awk '{if(NR>1)print}' >> coverage.txt |
There was a problem hiding this comment.
This might already be the case, but lets see if the coverage report can be in a format and placed in the right place for Circle to parse and display.
There was a problem hiding this comment.
good thinking. I was gonna look into how to do coverage reporting for Go at some point so we could also get a coverage badge on the repo or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #72
fixes #122
This PR adds in unit tests for checking the output of the CLI commands.