Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StripeExpandable decoding fix #138

Merged
merged 5 commits into from
Sep 23, 2021
Merged

StripeExpandable decoding fix #138

merged 5 commits into from
Sep 23, 2021

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Sep 23, 2021

No description provided.

@gwynne gwynne requested a review from Andrewangeta September 23, 2021 15:06
@Andrewangeta
Copy link
Member

@gwynne What about DynamicExpandable? 👀

@gwynne
Fix the Codable conformances on Expandable to be compliant (fixes sev…
b36e0f8 
…eral issues), fix the KeyedDecodingContainer override to specifically handle Expandable (fixes the missing "transfer" key issue), make the test show errors better. Oh, and some much better CI.
@Andrewangeta
Copy link
Member

Fixes #130

Andrewangeta
Andrewangeta approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@Andrewangeta Andrewangeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhh yes.....

@Andrewangeta Andrewangeta merged commit 84aab0c into main Sep 23, 2021
@Andrewangeta Andrewangeta mentioned this pull request Sep 23, 2021
Closed
@gwynne gwynne deleted the decode-fix branch September 23, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrewangeta Andrewangeta Andrewangeta approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gwynne @Andrewangeta