Async await #44
Open
Async await #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrote credential handling to be easier to use and more reliable.
added 7 commits
June 24, 2022 23:15
|
@Andrewangeta Is this PR ready for review? |
|
@nathanfallet Not quite. I really should take some time this week to finish up the implementation. If you want, you can use the current branch or even a specific commit hash. I've been using the branch for a while for cloud storage. |
|
There are conflicts so you might need to merge/rebase before continuing (or merging in the main branch). Keep us updated if you go further, that would be a great improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42
Starting to rewrite everything is async await.
This includes rewriting how credential loading works.
It's more accurate according to spec which it wasn't before.
And it's easier to use and has a more friendly API.
APIs to be converted: