Imperial Beta release: Google completion handler not called

[mynona]

There is an issue with the Google login flow as the completion handler doesn't get called.

func boot(routes: RoutesBuilder) throws {

      let googleCallbackURL = try getEnvironmentVariable(for: "GOOGLE_CALLBACK_URL")

      try routes.oAuth(
         from: Google.self,
         authenticate: "auth/google/",
         callback: googleCallbackURL,
         scope: ["profile", "email"],
         completion: processGoogleLogin
      )
   }

The routes seem to be correctly registered, but when I call the routes via postman I get a 404.
I would expect a 400 Bad Request as the route is called without code

[mynona]

@fpseverino

[fpseverino]

Trying it myself it seems like GOOGLE_CALLBACK_URL should contain only the path and not the full URL (e.g. oauth/google/ and not http://localhost:8080/oauth/google).

With the full URL I get a 404 when querying http://localhost:8080/oauth/google and a 400 when querying http://localhost:8080/http://localhost:8080/oauth/google.
Giving it only the path I get a 400 when querying http://localhost:8080/oauth/google (as it should be).

[fpseverino]

In the latest beta we switched from custom path components handling to RoutingKit, so it must be that.

[fpseverino]

On the bright side you should now not need the environment variable anymore as you can pass the path directly to it and it will be valid for development and production.

I think this is why the Kodeco book used environmental variables, and not for security reasons, but I'm not 100% sure.

[mynona]

Looks as Google has a different opinion on that:

[mynona]

Seems Google requires the full URL. Will it be possible to update Imperial that it will follow the same logic as before the beta release?

Thank you for your support!

[mynona]

Google does not allow adding URIs without https: or http: