Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and expose sorted output_names #196

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Save and expose sorted output_names #196

merged 1 commit into from
Jun 2, 2022

Conversation

elaubsch
Copy link
Member

@elaubsch elaubsch commented Jun 2, 2022

This PR fixes this issue. The GRPC client returns a dictionary with keys corresponding to the output names. These names were previously sorted but the sorted keys were not saved. Therefore, when these keys were exposed and used, sometimes they were in the wrong order.

@elaubsch elaubsch added the fix Fixes a bug label Jun 2, 2022
@elaubsch elaubsch requested a review from msschwartz21 June 2, 2022 22:13
@elaubsch elaubsch merged commit f696c05 into master Jun 2, 2022
@elaubsch elaubsch deleted the mly/sort_outputs branch June 2, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumer uses cached prediction if uploaded file name has been used previously
2 participants