Adding Polaris consumer #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msschwartz21
requested changes
Jan 21, 2022
There was a problem hiding this comment.
I left some comments for you to look at, but my big picture concern is to take a second look at the assumptions regarding data shape in PolarisConsumer._consume. My impression is that you are assuming that you are going to get a 2d image with a batch dimension added by get_image. Is that assertion enforced somewhere else in the code? Have you tried uploading data with non-standard dimensions to see how its tolerated?
elaubsch
commented
Jan 26, 2022
msschwartz21
requested changes
Jan 26, 2022
Co-authored-by: Morgan Schwartz <[email protected]>
Co-authored-by: Morgan Schwartz <[email protected]>
msschwartz21
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Polaris consumer and tests