Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Dependency management updates #141

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Jul 22, 2023

Three changes here:

  1. Update scikit-image version for consistency with deepcell-tf
  2. Update deprecated access patterns for scipy.signal
  3. Pin Cython version.

This last one is required to get the docker build working in deepcell-tf (see e.g. these failing jobs). I'm not sure exactly what the problem is and why it's only showing up in the docker and not in non-containerized environments, but pinning seems to fix it in local testing.

@rossbar rossbar added the chore Maintenance label Jul 22, 2023
@rossbar rossbar force-pushed the maint-bump-scikit-scipy branch from a960ef7 to f3782d4 Compare July 22, 2023 09:22
Fix deprecation warnings on scipy access patterns.
@rossbar rossbar force-pushed the maint-bump-scikit-scipy branch from f3782d4 to e93ddcb Compare July 22, 2023 09:26
@rossbar rossbar force-pushed the maint-bump-scikit-scipy branch 2 times, most recently from c339ac0 to 7be9bd0 Compare July 22, 2023 11:40
@rossbar rossbar force-pushed the maint-bump-scikit-scipy branch from 7be9bd0 to ec0b5e2 Compare July 22, 2023 11:48
@rossbar rossbar changed the title MAINT: bump scikit-image and scipy version. MAINT: Dependency management updates Jul 22, 2023
@rossbar
Copy link
Contributor Author

rossbar commented Aug 1, 2023

Merging to get the cython pin in, which is necessary to get the deepcell containers functioning again.

@rossbar rossbar merged commit 2fd19e9 into vanvalenlab:master Aug 1, 2023
@rossbar rossbar deleted the maint-bump-scikit-scipy branch August 1, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant