Fix scikit-image dependency specification #675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
There have been several deprecations and expirations of deprecations in
scikit-image
as of v0.18 that have affected the codebase. We caught most of these usages in vanvalenlab/deepcell-toolbox#131. Unfortunately, due to internal usage offunctools.wraps
, the stacklevel of some of the calls containing deprecated kwargs had changed, which prevented the DeprecationWarnings from being visible withindeepcell-tf
itself. This leads to all-out failures if scikit-image v0.21 is installed.This PR fixes the situation by:
Additional context
This should fix the situation for those who are just installing
deepcell
. Things get more complicated if e.g. a user has installeddeepcell-toolbox
separately. There will likely need to be changes along the lines of `vanvalenlab/deepcell-toolbox#136 as well for better coverage of different installation orders, etc.Why
Without the lower-bound pin, it is possible to install
deepcell
with a non-functional environment (i.e. ifscikit-image
is installed as a transitive dependency by some other package in the environment).