Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add grpc client interceptor to parse error #598

Merged
merged 3 commits into from
Apr 20, 2023
Merged

feat: add grpc client interceptor to parse error #598

merged 3 commits into from
Apr 20, 2023

Conversation

hwjiangkai
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #598 (bb141cd) into main (ee76217) will decrease coverage by 2.58%.
The diff coverage is 48.20%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   57.07%   54.50%   -2.58%     
==========================================
  Files         190      211      +21     
  Lines       15191    17047    +1856     
==========================================
+ Hits         8670     9291     +621     
- Misses       5884     7052    +1168     
- Partials      637      704      +67     
Impacted Files Coverage Δ
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/controller/trigger/worker/worker.go 78.45% <ø> (-1.55%) ⬇️
internal/gateway/config.go 60.60% <ø> (-0.51%) ⬇️
internal/gateway/gateway.go 57.64% <ø> (-10.03%) ⬇️
internal/gateway/proxy/auth.go 0.00% <ø> (ø)
internal/gateway/proxy/deadletter.go 0.00% <ø> (ø)
internal/gateway/proxy/direct.go 15.84% <ø> (-57.50%) ⬇️
internal/gateway/proxy/proxy.go 23.23% <ø> (+0.14%) ⬆️
internal/gateway/proxy/reigister.go 100.00% <ø> (ø)
internal/gateway/proxy/util.go 0.00% <ø> (ø)
... and 70 more

... and 56 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35053c...bb141cd. Read the comment docs.

Signed-off-by: jyjiangkai <[email protected]>
@hwjiangkai hwjiangkai added the co/client relating to eventbus client label Apr 19, 2023
Signed-off-by: jyjiangkai <[email protected]>
@ifplusor ifplusor changed the title feat: add client interceptor feat: add grpc client interceptor to parse error Apr 20, 2023
@ifplusor ifplusor merged commit 7f8f352 into main Apr 20, 2023
@ifplusor ifplusor deleted the error branch April 20, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/client relating to eventbus client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants