Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error type conversion #581

Merged
merged 1 commit into from
Mar 29, 2023
Merged

fix: error type conversion #581

merged 1 commit into from
Mar 29, 2023

Conversation

hwjiangkai
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@hwjiangkai hwjiangkai requested a review from ifplusor March 29, 2023 06:39
@hwjiangkai hwjiangkai requested a review from wenfengwang as a code owner March 29, 2023 06:39
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #581 (2519e1e) into main (ee76217) will decrease coverage by 2.34%.
The diff coverage is 45.59%.

❗ Current head 2519e1e differs from pull request most recent head 8d60c09. Consider uploading reports for the commit 8d60c09 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
- Coverage   57.07%   54.73%   -2.34%     
==========================================
  Files         190      211      +21     
  Lines       15191    16918    +1727     
==========================================
+ Hits         8670     9260     +590     
- Misses       5884     6960    +1076     
- Partials      637      698      +61     
Impacted Files Coverage Δ
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/gateway/proxy/auth.go 0.00% <0.00%> (ø)
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/gateway/proxy/direct.go 15.84% <ø> (-57.50%) ⬇️
internal/gateway/proxy/proxy.go 23.23% <ø> (+0.14%) ⬆️
internal/gateway/proxy/reigister.go 100.00% <ø> (ø)
internal/gateway/proxy/util.go 0.00% <ø> (ø)
...nternal/primitive/authentication/authentication.go 34.09% <ø> (ø)
internal/primitive/authentication/client.go 0.00% <ø> (ø)
internal/primitive/authorization/action.go 0.00% <ø> (ø)
... and 73 more

... and 56 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9938385...8d60c09. Read the comment docs.

Signed-off-by: jyjiangkai <[email protected]>
Copy link
Collaborator

@ifplusor ifplusor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwjiangkai hwjiangkai merged commit 573f724 into main Mar 29, 2023
@ifplusor ifplusor deleted the errortype branch April 10, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants