Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert rpcerr to ErrorType #580

Merged
merged 1 commit into from
Mar 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/cluster/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"google.golang.org/protobuf/types/known/wrapperspb"

"github.com/vanus-labs/vanus/pkg/cluster/raw_client"
"github.com/vanus-labs/vanus/pkg/errors"
ctrlpb "github.com/vanus-labs/vanus/proto/pkg/controller"
metapb "github.com/vanus-labs/vanus/proto/pkg/meta"
)
Expand All @@ -31,15 +32,15 @@ type authService struct {
func (a *authService) GetUserRole(ctx context.Context, user string) ([]*metapb.UserRole, error) {
resp, err := a.client.GetUserRole(ctx, &ctrlpb.GetUserRoleRequest{UserIdentifier: user})
if err != nil {
return nil, err
return nil, errors.To(err)
}
return resp.GetUserRole(), nil
}

func (a *authService) GetUserByToken(ctx context.Context, token string) (string, error) {
user, err := a.client.GetUserByToken(ctx, wrapperspb.String(token))
if err != nil {
return "", err
return "", errors.To(err)
}
return user.GetValue(), nil
}
Expand Down
13 changes: 7 additions & 6 deletions pkg/cluster/eventbus.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ func (es *eventbusService) GetEventbusByName(ctx context.Context, ns, name strin

pb, err := es.nsSvc.GetNamespaceByName(ctx, ns)
if err != nil {
return nil, err
return nil, errors.To(err)
}
eb, err := es.client.GetEventbusWithHumanFriendly(ctx, &ctrlpb.GetEventbusWithHumanFriendlyRequest{
NamespaceId: pb.Id,
EventbusName: name,
})
if err != nil {
return nil, err
return nil, errors.To(err)
}

// es.cache.Store(key, eb) unmask when dirty cache is resolved
Expand All @@ -66,7 +66,7 @@ func (es *eventbusService) GetEventbus(ctx context.Context, id uint64) (*meta.Ev

eb, err := es.client.GetEventbus(ctx, wrapperspb.UInt64(id))
if err != nil {
return nil, err
return nil, errors.To(err)
}

// es.cache.Store(id, eb) unmask when dirty cache is resolved
Expand All @@ -93,20 +93,21 @@ func (es *eventbusService) CreateSystemEventbusIfNotExist(ctx context.Context, n

nsPb, err := es.nsSvc.GetSystemNamespace(ctx)
if err != nil {
return nil, err
return nil, errors.To(err)
}

return es.client.CreateSystemEventbus(ctx, &ctrlpb.CreateEventbusRequest{
eventbus, err := es.client.CreateSystemEventbus(ctx, &ctrlpb.CreateEventbusRequest{
Name: name,
LogNumber: int32(defaultSystemEventbusEventlog),
Description: desc,
NamespaceId: nsPb.Id,
})
return eventbus, errors.To(err)
}

func (es *eventbusService) Delete(ctx context.Context, id uint64) error {
_, err := es.client.DeleteEventbus(ctx, wrapperspb.UInt64(id))
return err
return errors.To(err)
}

func (es *eventbusService) RawClient() ctrlpb.EventbusControllerClient {
Expand Down
8 changes: 5 additions & 3 deletions pkg/cluster/namespace.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@ package cluster

import (
"context"
"google.golang.org/protobuf/types/known/wrapperspb"
"sync"

"google.golang.org/protobuf/types/known/wrapperspb"

"github.com/vanus-labs/vanus/pkg/cluster/raw_client"
"github.com/vanus-labs/vanus/pkg/errors"
ctrlpb "github.com/vanus-labs/vanus/proto/pkg/controller"
metapb "github.com/vanus-labs/vanus/proto/pkg/meta"
)
Expand All @@ -41,7 +43,7 @@ func (ns *namespaceService) GetNamespace(ctx context.Context, id uint64) (*metap
}
n, err := ns.client.GetNamespace(ctx, &ctrlpb.GetNamespaceRequest{Id: id})
if err != nil {
return nil, err
return nil, errors.To(err)
}
// ns.cache.Store(id, n) unmask when dirty cache is resolved
return n, nil
Expand All @@ -62,7 +64,7 @@ func (ns *namespaceService) GetNamespaceByName(ctx context.Context, name string)
}
n, err := ns.client.GetNamespaceWithHumanFriendly(ctx, wrapperspb.String(name))
if err != nil {
return nil, err
return nil, errors.To(err)
}
// ns.cache.Store(name, n) unmask when dirty cache is resolved
return n, nil
Expand Down
4 changes: 3 additions & 1 deletion pkg/cluster/trigger.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
metapb "github.com/vanus-labs/vanus/proto/pkg/meta"

"github.com/vanus-labs/vanus/pkg/cluster/raw_client"
"github.com/vanus-labs/vanus/pkg/errors"
)

type triggerService struct {
Expand All @@ -27,5 +28,6 @@ func (es *triggerService) RegisterHeartbeat(ctx context.Context, interval time.D
}

func (es *triggerService) GetSubscription(ctx context.Context, id uint64) (*metapb.Subscription, error) {
return es.client.GetSubscription(ctx, &ctrlpb.GetSubscriptionRequest{Id: id})
subscription, err := es.client.GetSubscription(ctx, &ctrlpb.GetSubscriptionRequest{Id: id})
return subscription, errors.To(err)
}
5 changes: 5 additions & 0 deletions pkg/errors/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ func Is(err error, target error) bool {
return errType != nil && errType.Code == targetType.Code
}

func To(err error) *ErrorType {
et, _ := FromError(err)
return et
}

func FromError(err error) (*ErrorType, bool) {
if err == nil {
return nil, true
Expand Down