Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add container resources param for cluster subcommand #571

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Conversation

hwjiangkai
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@hwjiangkai hwjiangkai requested a review from wenfengwang as a code owner March 23, 2023 08:21
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #571 (93f6b3e) into main (ee76217) will decrease coverage by 0.88%.
The diff coverage is 53.95%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   57.07%   56.19%   -0.88%     
==========================================
  Files         190      194       +4     
  Lines       15191    15685     +494     
==========================================
+ Hits         8670     8814     +144     
- Misses       5884     6218     +334     
- Partials      637      653      +16     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 35.93% <0.00%> (-16.70%) ⬇️
internal/controller/eventbus/block/selector.go 91.66% <ø> (-8.34%) ⬇️
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/primitive/cel/cel.go 68.57% <0.00%> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/queue/queue.go 87.87% <ø> (ø)
internal/primitive/transform/action/action.go 11.94% <ø> (ø)
... and 70 more

... and 40 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f91de...93f6b3e. Read the comment docs.

Signed-off-by: jyjiangkai <[email protected]>
@hwjiangkai hwjiangkai merged commit 19445de into main Mar 24, 2023
@hwjiangkai hwjiangkai deleted the cluster branch March 24, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants