Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): use default ports when missing #551

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

ifplusor
Copy link
Collaborator

What problem does this PR solve?

Issue Number: None

Problem Summary

When ports is missing from the configure file, gateway will start without listening.

What is changed and how does it work?

Use default ports when missing.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@ifplusor ifplusor requested a review from hwjiangkai as a code owner March 16, 2023 03:16
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #551 (d58169a) into main (ee76217) will decrease coverage by 1.23%.
The diff coverage is 46.82%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
- Coverage   57.07%   55.85%   -1.23%     
==========================================
  Files         190      191       +1     
  Lines       15191    15532     +341     
==========================================
+ Hits         8670     8675       +5     
- Misses       5884     6211     +327     
- Partials      637      646       +9     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 35.93% <0.00%> (-16.70%) ⬇️
internal/controller/eventbus/block/selector.go 91.66% <ø> (-8.34%) ⬇️
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/primitive/cel/cel.go 68.57% <0.00%> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/queue/queue.go 87.87% <ø> (ø)
internal/primitive/transform/action/action.go 11.94% <ø> (ø)
... and 70 more

... and 39 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965206c...d58169a. Read the comment docs.

@ifplusor ifplusor merged commit d9db021 into vanus-labs:main Mar 16, 2023
@ifplusor ifplusor deleted the gateway-default-port branch March 16, 2023 03:20
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants