Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: the default metadata key_prefix configuration is empty #537

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

hwjiangkai
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #537 (8aef514) into main (ee76217) will decrease coverage by 1.13%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
- Coverage   57.07%   55.94%   -1.13%     
==========================================
  Files         190      191       +1     
  Lines       15191    15495     +304     
==========================================
- Hits         8670     8669       -1     
- Misses       5884     6182     +298     
- Partials      637      644       +7     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 35.93% <0.00%> (-16.70%) ⬇️
internal/controller/eventbus/block/selector.go 91.66% <ø> (-8.34%) ⬇️
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/gateway/config.go 61.11% <ø> (ø)
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/primitive/cel/cel.go 68.57% <0.00%> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/queue/queue.go 87.87% <ø> (ø)
... and 94 more

... and 31 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b78c2c...8aef514. Read the comment docs.

xdlbdy
xdlbdy previously approved these changes Mar 13, 2023
Copy link
Contributor

@xdlbdy xdlbdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdlbdy
Copy link
Contributor

xdlbdy commented Mar 13, 2023

do you forget to modify configmap timer in aws-eks.yaml

@wenfengwang wenfengwang merged commit 963496f into main Mar 13, 2023
@wenfengwang wenfengwang deleted the vsctl branch March 14, 2023 05:32
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants