Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add namespace #523

Merged
merged 5 commits into from
Mar 12, 2023
Merged

feat: add namespace #523

merged 5 commits into from
Mar 12, 2023

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Mar 11, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@xdlbdy
feat: add namespace
283974a 
Signed-off-by: xdlbdy <[email protected]>
@xdlbdy xdlbdy requested a review from wenfengwang as a code owner March 11, 2023 12:22
@xdlbdy xdlbdy marked this pull request as draft March 11, 2023 12:22
xdlbdy added 2 commits March 11, 2023 20:38
@xdlbdy
feat: add namespace
be60055 
Signed-off-by: xdlbdy <[email protected]>
@xdlbdy
feat: add namespace
12068cc 
Signed-off-by: xdlbdy <[email protected]>
@xdlbdy xdlbdy marked this pull request as ready for review March 12, 2023 01:59
xdlbdy added 2 commits March 12, 2023 10:11
@xdlbdy
feat: add namespace
a7a6f3e 
Signed-off-by: xdlbdy <[email protected]>
@xdlbdy
feat: add namespace
3ebc7a1 
Signed-off-by: xdlbdy <[email protected]>
wenfengwang
wenfengwang approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@wenfengwang wenfengwang merged commit ca16ed8 into vanus-labs:main Mar 12, 2023
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
@xdlbdy
feat: add namespace (#523)
651597f 
* feat: add namespace

Signed-off-by: xdlbdy <[email protected]>

* feat: add namespace

Signed-off-by: xdlbdy <[email protected]>

* feat: add namespace

Signed-off-by: xdlbdy <[email protected]>

* feat: add namespace

Signed-off-by: xdlbdy <[email protected]>

* feat: add namespace

Signed-off-by: xdlbdy <[email protected]>

---------

Signed-off-by: xdlbdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenfengwang wenfengwang wenfengwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xdlbdy @wenfengwang