Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trigger): eventbus name change to id #504

Merged
merged 5 commits into from
Mar 9, 2023

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Mar 9, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@xdlbdy xdlbdy marked this pull request as draft March 9, 2023 03:49
@xdlbdy xdlbdy marked this pull request as ready for review March 9, 2023 09:58
@xdlbdy xdlbdy requested a review from ifplusor March 9, 2023 09:58
Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit 9f651ad into vanus-labs:main Mar 9, 2023
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
* feat(trigger): eventbus name change to id

Signed-off-by: xdlbdy <[email protected]>

* feat(trigger): eventbus name change to id

Signed-off-by: xdlbdy <[email protected]>

* feat(trigger): eventbus name change to id

Signed-off-by: xdlbdy <[email protected]>

* feat(trigger): eventbus name change to id

Signed-off-by: xdlbdy <[email protected]>

* feat(trigger): eventbus name change to id

Signed-off-by: xdlbdy <[email protected]>

---------

Signed-off-by: xdlbdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants