refactor: Function capitalize word #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: in CapitalizeWord add strings.Join(capWords, " ") to return.
|
pls resolve conflict |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
- Coverage 57.71% 57.20% -0.51%
==========================================
Files 180 184 +4
Lines 14614 15005 +391
==========================================
+ Hits 8434 8584 +150
- Misses 5552 5791 +239
- Partials 628 630 +2
Continue to review full report at Codecov.
|
wenfengwang
pushed a commit
that referenced
this pull request
Mar 23, 2023
* feat: implement function capitalize_word * test: add test TestCapitalizeWordAction fix: in CapitalizeWord add strings.Join(capWords, " ") to return. * fix: in CapitalizeWord use Fields instead of Split to takecare of dup spaces. * fix: redo function to keep spaces and handle unicode, add tests. * fix: update comment for NewCapitalizeWordAction * refactor: better readability, cleaner code in CapitalizeWord. Add test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #488
Problem Summary
Team, thank you for the quick PR review.
By email I got xdlbdy's comment with implementation idea, (not sure how to find it on GitHub) so here is the screenshot:
Questions:
!unicode.IsSpaceas a criteria that we are inWord? If we useunicode.IsLetter(r) || unicode.IsNumber(r)the logic will treat other symbols as notinWord. For example a stringlet 'em go, will be capitalized toLet 'Em Go. I guess the question is, how do we want to capitalize cases like'emand other cases where the word starts with a symbol that is neither a number nor a letter.What is changed and how does it work?
[]runefrom the get go.'em'em.Check List
Tests