Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge the publish and send interfaces #398

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

hwjiangkai
Copy link
Contributor

Signed-off-by: jyjiangkai [email protected]

What problem does this PR solve?

merge the publish and send interfaces

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #398 (5d9a24f) into main (09f3748) will decrease coverage by 2.93%.
The diff coverage is 50.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   62.72%   59.78%   -2.94%     
==========================================
  Files         133      172      +39     
  Lines       12128    14101    +1973     
==========================================
+ Hits         7607     8430     +823     
- Misses       3977     5076    +1099     
- Partials      544      595      +51     
Impacted Files Coverage Δ
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/trigger/storage/secret.go 48.48% <ø> (ø)
...nternal/controller/trigger/storage/subscription.go 54.71% <ø> (ø)
...ernal/controller/trigger/storage/trigger_worker.go 63.41% <ø> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/vanus/id.go 19.68% <0.00%> (-0.65%) ⬇️
internal/raft/log/recovery.go 52.27% <ø> (ø)
internal/raft/log/wal.go 100.00% <ø> (ø)
internal/store/block/entry.go 70.96% <ø> (ø)
... and 155 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2789120...5d9a24f. Read the comment docs.

@wenfengwang wenfengwang merged commit 89f80c3 into vanus-labs:main Jan 7, 2023
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
Signed-off-by: jyjiangkai <[email protected]>

Signed-off-by: jyjiangkai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants