Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): broken wal format #386

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

ifplusor
Copy link
Collaborator

@ifplusor ifplusor commented Jan 5, 2023

What problem does this PR solve?

Issue Number: None

Problem Summary

WAL format is broken, and causes panic in recovery. (after #324)

image

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@ifplusor ifplusor requested a review from wenfengwang January 5, 2023 10:06
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #386 (5382186) into main (09f3748) will decrease coverage by 1.85%.
The diff coverage is 54.11%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
- Coverage   62.72%   60.86%   -1.86%     
==========================================
  Files         133      170      +37     
  Lines       12128    13730    +1602     
==========================================
+ Hits         7607     8357     +750     
- Misses       3977     4788     +811     
- Partials      544      585      +41     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 56.09% <0.00%> (ø)
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/trigger/storage/secret.go 48.48% <ø> (ø)
...nternal/controller/trigger/storage/subscription.go 54.71% <ø> (ø)
...ernal/controller/trigger/storage/trigger_worker.go 63.41% <ø> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/vanus/id.go 19.68% <0.00%> (-0.65%) ⬇️
internal/raft/log/recovery.go 52.27% <ø> (ø)
internal/raft/log/wal.go 100.00% <ø> (ø)
... and 149 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea3797...5382186. Read the comment docs.

Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit e84055c into vanus-labs:main Jan 5, 2023
@ifplusor ifplusor deleted the fix-wal-format branch January 5, 2023 11:11
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
Signed-off-by: James Yin <[email protected]>

Signed-off-by: James Yin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants