Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add transformer function condition if #353

Merged
merged 1 commit into from
Dec 20, 2022
Merged

feat: add transformer function condition if #353

merged 1 commit into from
Dec 20, 2022

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Dec 19, 2022

Signed-off-by: delu [email protected]

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

  • add transformer function condition if, it's used like below:
["condition_if","$.targetPath","$.path","op","compareValue","trueValue","falseValue"]

op only support ==, >=, >, <=, <

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@xdlbdy xdlbdy requested a review from wenfengwang as a code owner December 19, 2022 11:10
wenfengwang
wenfengwang approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit 4ed721d into vanus-labs:main Dec 20, 2022
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
@xdlbdy
feat: add transformer function condition if (#353)
3fb8336 
Signed-off-by: delu <[email protected]>

Signed-off-by: delu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenfengwang wenfengwang wenfengwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xdlbdy @wenfengwang