Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ValidateSubscription in gateway #351

Merged
merged 4 commits into from
Dec 19, 2022

Conversation

wenfengwang
Copy link
Contributor

Signed-off-by: wenfeng [email protected]

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

add ValidateSubscription in the gateway to vsctl and console

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Merging #351 (0391eb1) into main (09f3748) will increase coverage by 0.42%.
The diff coverage is 61.79%.

❗ Current head 0391eb1 differs from pull request most recent head 8d5f923. Consider uploading reports for the commit 8d5f923 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   62.72%   63.14%   +0.42%     
==========================================
  Files         133      144      +11     
  Lines       12128    13216    +1088     
==========================================
+ Hits         7607     8345     +738     
- Misses       3977     4282     +305     
- Partials      544      589      +45     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 56.09% <0.00%> (ø)
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/eventbus/server/manager.go 66.66% <ø> (ø)
internal/controller/trigger/storage/secret.go 48.48% <ø> (ø)
...nternal/controller/trigger/storage/subscription.go 54.71% <ø> (ø)
...ernal/controller/trigger/storage/trigger_worker.go 63.41% <ø> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/vanus/id.go 19.84% <0.00%> (-0.49%) ⬇️
internal/raft/log/wal.go 100.00% <ø> (ø)
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e696fa7...8d5f923. Read the comment docs.

@wenfengwang wenfengwang force-pushed the feat-support-subscription-validate branch from 0391eb1 to 8d5f923 Compare December 19, 2022 08:45
Copy link
Contributor

@xdlbdy xdlbdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit d8249cc into main Dec 19, 2022
@wenfengwang wenfengwang deleted the feat-support-subscription-validate branch January 5, 2023 08:09
wenfengwang added a commit that referenced this pull request Mar 23, 2023
* feat: add ValidateSubscription in gateway

Signed-off-by: wenfeng <[email protected]>

* updating according to code review

Signed-off-by: wenfeng <[email protected]>

* update test data

Signed-off-by: wenfeng <[email protected]>

* fix bug

Signed-off-by: wenfeng <[email protected]>

Signed-off-by: wenfeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants