-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ValidateSubscription in gateway #351
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 62.72% 63.14% +0.42%
==========================================
Files 133 144 +11
Lines 12128 13216 +1088
==========================================
+ Hits 7607 8345 +738
- Misses 3977 4282 +305
- Partials 544 589 +45
Continue to review full report at Codecov.
|
Signed-off-by: wenfeng <[email protected]>
Signed-off-by: wenfeng <[email protected]>
Signed-off-by: wenfeng <[email protected]>
Signed-off-by: wenfeng <[email protected]>
0391eb1
to
8d5f923
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: add ValidateSubscription in gateway Signed-off-by: wenfeng <[email protected]> * updating according to code review Signed-off-by: wenfeng <[email protected]> * update test data Signed-off-by: wenfeng <[email protected]> * fix bug Signed-off-by: wenfeng <[email protected]> Signed-off-by: wenfeng <[email protected]>
Signed-off-by: wenfeng [email protected]
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary
add
ValidateSubscription
in the gateway to vsctl and consoleWhat is changed and how does it work?
Check List
Tests