Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Memory Leak with setOnApplyWindowInsetsListener. #569

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

vanniktech
Copy link
Owner

    ┬───
    │ GC Root: System class
    │
    ├─ android.view.inputmethod.InputMethodManager class
    │    Leaking: NO (InputMethodManager↓ is not leaking and a class is never leaking)
    │    ↓ static InputMethodManager.sInstance
    ├─ android.view.inputmethod.InputMethodManager instance
    │    Leaking: NO (DecorView↓ is not leaking and InputMethodManager is a singleton)
    │    ↓ InputMethodManager.mCurRootView
    ├─ android.view.ViewRootImpl instance
    │    Leaking: NO (DecorView↓ is not leaking)
    │    mContext instance of com.android.internal.policy.DecorContext, wrapping activity app.becoach.android.coach.
    │    CoachTabBarActivity with mDestroyed = false
    │    ViewRootImpl#mView is not null
    │    mWindowAttributes.mTitle = "app.becoach.android.coach.dev/app.becoach.android.coach.CoachTabBarActivity"
    │    mWindowAttributes.type = 1
    │    ↓ ViewRootImpl.mView
    ├─ com.android.internal.policy.DecorView instance
    │    Leaking: NO (View attached)
    │    View is part of a window view hierarchy
    │    View.mAttachInfo is not null (view attached)
    │    View.mWindowAttachCount = 1
    │    mContext instance of com.android.internal.policy.DecorContext, wrapping activity app.becoach.android.coach.
    │    CoachTabBarActivity with mDestroyed = false
    │    ↓ View.mListenerInfo
    │           ~~~~~~~~~~~~~
    ├─ android.view.View$ListenerInfo instance
    │    Leaking: UNKNOWN
    │    Retaining 579.3 kB in 7126 objects
    │    ↓ View$ListenerInfo.mOnApplyWindowInsetsListener
    │                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ├─ com.vanniktech.emoji.EmojiPopup$5 instance
    │    Leaking: UNKNOWN
    │    Retaining 579.1 kB in 7120 objects
    │    Anonymous class implementing android.view.View$OnApplyWindowInsetsListener
    │    ↓ EmojiPopup$5.this$0
    │                   ~~~~~~

@vanniktech vanniktech requested review from mario and rubengees April 5, 2022 18:51
@vanniktech
Copy link
Owner Author

Anyone @mario / @rubengees ?

Copy link
Collaborator

@rubengees rubengees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct 👍

@vanniktech vanniktech merged commit d6cce7b into master Apr 8, 2022
@vanniktech vanniktech deleted the memory-leak branch April 8, 2022 17:25
@mario
Copy link
Collaborator

mario commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants