fix: use OpenMP flag to avoid macOS segfault #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kahtaf
approved these changes
Mar 18, 2024
| @@ -35,4 +35,13 @@ echo "Running llama-cpp-python-cublas.sh to enable hardware acceleration..." | |||
| ./scripts/llama-cpp-python-cublas.sh | |||
|
|
|||
| echo "Running selfie..." | |||
|
|
|||
| if [ "$(uname -m)" = "arm64" ]; then | |||
There was a problem hiding this comment.
arm64 can be Linux too no? Is it okay?
There was a problem hiding this comment.
We could also check if uname -s matches Darwin, but I'm not sure if this is limited to Macs only... it should be okay to use a conservative setting here. Maybe it impacts performance, I'm not sure.
Ultimately it would be great if we can remove both of these flags, especially KMP_DUPLICATE_LIB_OK, which doesn't appear to be a 100% reliable fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33 (hopefully), as well as a bug preventing completions from generating successfully.