feat: Telegram and Text Files connectors #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kahtaf
approved these changes
Feb 28, 2024
README.md
Outdated
|
|
||
| On the roadmap: | ||
| * Load data using any [LlamaHub loader](https://llamahub.ai/?tab=loaders) (partial support is available through the API). | ||
| * Directly and selectively query loaded data. | ||
| * Load data using any [LlamaHub loader](https://llamahub.ai/?tab=loaders). |
There was a problem hiding this comment.
Is this on the roadmap? I thought we were going with the approach of "one connector for each data source" vs "support all llamahub loaders", because the E2E flow for each connector varies.
There was a problem hiding this comment.
I think a general-purpose LlamaHub loader should be possible, probably with some limitations (some loaders need additional python dependencies), but I've removed it until we can clarify further.
| return [ | ||
| DocumentDTO( | ||
| content=data_uri_to_string(data_uri), | ||
| content_type="text/plain", |
There was a problem hiding this comment.
Should this be application/json?
| return [ | ||
| DocumentDTO( | ||
| content=data_uri_to_string(data_uri), | ||
| content_type="text/plain", |
tnunamak
commented
Feb 28, 2024
tnunamak
commented
Feb 28, 2024
tnunamak
commented
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.