Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Client ms cleaner #975

Merged
merged 5 commits into from
Feb 22, 2021
Merged

Fix Client ms cleaner #975

merged 5 commits into from
Feb 22, 2021

Conversation

kiyonlin
Copy link
Contributor

Currently we only start a gorouting for cleaning Client.m, but no one for Client.ms.

@erikdubbelboer erikdubbelboer merged commit 62dfc52 into valyala:master Feb 22, 2021
@erikdubbelboer
Copy link
Collaborator

Thanks! I have no idea how this went unnoticed for so long.

@kiyonlin kiyonlin deleted the client-mcleaner branch February 23, 2021 07:14
@moredure
Copy link
Contributor

moredure commented Feb 24, 2021 •
edited
Loading

@kiyonlin Great job, I love it))!

@moredure
Copy link
Contributor

But it's not a fix) there is an another issue)

if len(c.m) == 0 {
mustStop = true mustStop = true
} }
etc (

@moredure moredure mentioned this pull request Feb 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiyonlin @erikdubbelboer @moredure