-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:support zstd compress and uncompressed #1701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing.
Cause compress is declaring |
Still failing. |
Compress minimum Go version is 1.19, downgrading is not a good idea since it will not have the corruption fixes made to @erikdubbelboer Any timeline for fasthttp to bump the min go version? |
I'm ok with you dropping 1.18 support in this pull. It's not officially maintained by the Go team either. |
@@ -150,7 +151,7 @@ func nonblockingWriteZstd(ctxv any) { | |||
|
|||
// AppendZstdBytes appends zstd src to dst and returns the resulting dst. | |||
func AppendZstdBytes(dst, src []byte) []byte { | |||
return AppendZstdBytesLevel(dst, src, CompressBrotliDefaultCompression) | |||
return AppendZstdBytesLevel(dst, src, CompressZstdDefault) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still linting errors and it needs to be rebased on master now.
c7885dc
to
3754ffc
Compare
Please Hold. I'll fix this wrong commiter by rebase |
3754ffc
to
41e4eb6
Compare
@erikdubbelboer fixed,need squash those commit? |
@erikdubbelboer The timeouts in the tests are too agressive. The same error happens in a different PR https://github.com/valyala/fasthttp/actions/runs/7881870997/job/21506194694?pr=1720 |
@alexandear @erikdubbelboer @Max-Cheng Can someone rebase with master to see what's left on this PR? |
95ac420
to
1d133df
Compare
@erikdubbelboer If you add this to the lint workflow before the job, it will show you here on Github where the issues are: permissions:
# Required: allow read access to the content for analysis.
contents: read
# Optional: allow read access to pull request. Use with `only-new-issues` option.
pull-requests: read
# Optional: Allow write access to checks to allow the action to annotate code in the PR.
checks: write Example: https://github.com/gofiber/fiber/blob/main/.github/workflows/linter.yml |
1d133df
to
442178d
Compare
442178d
to
6484a90
Compare
@gaby thanks for the suggestion. I think everything is fixed now and this can be merged. |
No description provided.