fix missing argument to load method of Loader #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recording is enabled and a graphql request comes in that should be persisted, the call to
load
(to see whether the query id already exists or not) does not have the correct amount of arguments. The call needs to pass the operation name toload
.This PR fixes this and adds a test for it. Let me know if you would like me to take a different approach to the test, specifically the
enableRecording()
/resetRecording()
setup. Wasn't sure how you wanted to handle database mutations for the unit tests @esamattis