Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slf4j Odin backend #350

Closed
jarrodcodes opened this issue Sep 15, 2021 · 1 comment
Closed

Slf4j Odin backend #350

jarrodcodes opened this issue Sep 15, 2021 · 1 comment

Comments

@jarrodcodes
Copy link
Contributor

Hi there. We are greatly enjoying Odin and will most likely switch to it from log4cats. However, if we are going to use Odin, we would want the ability in our published libraries to have an slf4j backend version so that consumers of those libraries will have a no hassle implicit logger available. I was curious if the maintainers would accept a PR that offers an Odin logger with an slf4j backend, similar to log4cats's Slf4jLogger.
jarrodcodes pushed a commit to jarrodcodes/thoth that referenced this issue Sep 16, 2021
valskalla#350 Add Slf4j logging implementation
28d2ac0
@jarrodcodes
Copy link
Contributor Author

I went ahead and made a PR that would add this functionality. Looking forward to any feedback. Thanks!

jarrodcodes pushed a commit to jarrodcodes/thoth that referenced this issue Sep 16, 2021
valskalla#350 Better test
db8e976
jarrodcodes pushed a commit to jarrodcodes/thoth that referenced this issue Sep 16, 2021
valskalla#350 Better test
acd11ce
jarrodcodes pushed a commit to jarrodcodes/thoth that referenced this issue Sep 16, 2021
valskalla#350 Better test
2694b53
jarrodcodes pushed a commit to jarrodcodes/thoth that referenced this issue Sep 16, 2021
valskalla#350 Feedback
9794010
sergeykolbasov pushed a commit that referenced this issue Sep 17, 2021
@jarrodcodes
#350 Add Slf4j logging implementation (#352)
d34fae7 
* #350 Add Slf4j logging implementation

* #350 Better test

* #350 Better test

* #350 Better test

* #350 Feedback

Co-authored-by: Jarrod Young <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jarrodcodes