Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit earlier click version #739

Conversation

evangriffiths
Copy link

@evangriffiths evangriffiths commented Apr 29, 2024

Proposed changes

Downgrade minimum click version back to 1.51.0 release version (i.e. undoing min version bump from #736)

Fixes

#736 will introduce dependency conflicts in upstream projects that depend on both https://github.com/valory-xyz/open-aea and https://github.com/valory-xyz/open-autonomy (like https://github.com/valory-xyz/mech-client) in the next release of this repo (1.52.0). This change fixes that.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Release summary

This should be included in release 1.52.0 (for which release notes were added in https://github.com/valory-xyz/open-aea/pull/736/files)

@evangriffiths evangriffiths marked this pull request as draft April 29, 2024 17:40
@evangriffiths evangriffiths marked this pull request as ready for review April 30, 2024 08:41
@evangriffiths evangriffiths mentioned this pull request Apr 30, 2024
12 tasks
@angrybayblade
Copy link

angrybayblade commented May 5, 2024

@evangriffiths open-autonomy and mech-client are downstream dependencies which can be updated to match the open-aea dependency versions so there won't be any breaking changes.

@evangriffiths
Copy link
Author

@angrybayblade There would be breaking changes for any project with a dependency click==8.0.2. I can see that open-autonomy updated okay though with this new min version constraint, so that's good valory-xyz/open-autonomy@63a54d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants