Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port HTTP server as valory package #682

Merged
merged 16 commits into from
Oct 10, 2023
Merged

Conversation

angrybayblade
Copy link

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Adamantios
Adamantios previously approved these changes Oct 9, 2023
dvilelaf
dvilelaf previously approved these changes Oct 9, 2023
@angrybayblade angrybayblade dismissed stale reviews from dvilelaf and Adamantios via bf0e755 October 9, 2023 13:44
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e861ca4) 91.94% compared to head (3a13325) 91.92%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
- Coverage   91.94%   91.92%   -0.03%     
==========================================
  Files         371      371              
  Lines       29621    29646      +25     
==========================================
+ Hits        27236    27253      +17     
- Misses       2385     2393       +8     
Flag Coverage Δ
unittests 91.92% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aea/__version__.py 100.00% <100.00%> (ø)
...ackages/valory/connections/http_server/__init__.py 0.00% <ø> (ø)
...kages/valory/connections/http_server/connection.py 100.00% <100.00%> (ø)
aea/helpers/ipfs/base.py 94.73% <42.85%> (-4.63%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angrybayblade angrybayblade merged commit 099751e into main Oct 10, 2023
36 checks passed
@DavidMinarsch DavidMinarsch deleted the feat/port-http-server branch October 12, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants