fix: debug multiple account request #580
Conversation
| @@ -68,7 +68,8 @@ const useAllStakingContractDetails = () => { | |||
| {} as Record<string, Partial<StakingContractDetails>>, | |||
| ); | |||
|
|
|||
| const isAllStakingContractDetailsLoaded = queryResults.every( | |||
| // TODO: some are failing, not sure why. | |||
There was a problem hiding this comment.
can be due to forks/testnets
There was a problem hiding this comment.
Hmm, but "every" still doesn’t feel right. I think we should just remove the failed ones.
| @@ -62,7 +62,17 @@ export const StakingContractDetails = ({ | |||
| ); | |||
| } | |||
|
|
|||
| if (!list || list.length === 0) { | |||
There was a problem hiding this comment.
fixes
another.mov
| // DO NOTE REMOVE THIS DELAY | ||
| // NOTE: the delay is added so that agentType is updated in electron store | ||
| // and re-rendered with the updated agentType | ||
| await delayInSeconds(0.5); |
There was a problem hiding this comment.
ahh interesting, love such hacks :D
but ideally would store a reference to the new value (or a state), update it inside the handleSelectAgent right after updating the store value, and then in a separate useEffect would check the value from store, compare it with the ref (or state) and call all the below
but this fine with me too, so approving
There was a problem hiding this comment.
I think it was the same as what you are mentioning 🙈 , but adding a delay is a better than overcomplicating things with two states pointing to the same value and keeping them in sync. WDYT?
There was a problem hiding this comment.
it's not pointing to the same values, it's just the matter of synchronising them :D something similar to what we do on login when checking if the onboarding wasn't complete. just hope 0.5 sec delay is 100% stable
Proposed changes
2 issues posted by Iason
I believe it’s a race condition where agentType isn’t updated due to the behavior of Electron Store. Please check the video below.
create-new.mp4
switch.mp4
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply