Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Refactor (protocol.py): Clean patches #433

Closed

Conversation

OjusWiZard
Copy link
Member

Proposed changes

Gt rid of the patches and run the same logic at initialisation.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@jmoreira-valory
Copy link
Collaborator

I propose do not merge this PR yet. A more acurate and detailed analysis has to be conducted in relation to the implication that the object _ChainUtil has on external objects like ChainConfigs and ContractConfigs. A more robust approach should be designed so that no such side-effects take place outside certain objects.

@jmoreira-valory jmoreira-valory changed the title Refactor (protocol.py): Clean patches [Do not merge] Refactor (protocol.py): Clean patches Nov 11, 2024
@DavidMinarsch DavidMinarsch deleted the branch feat/allow-multiple-services-middleware December 15, 2024 05:05
@DavidMinarsch DavidMinarsch deleted the fix/patches branch December 15, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants